Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm deploy instructions #31751

Merged
merged 1 commit into from
Oct 23, 2023
Merged

update helm deploy instructions #31751

merged 1 commit into from
Oct 23, 2023

Conversation

git-phu
Copy link
Contributor

@git-phu git-phu commented Oct 23, 2023

What

mention constraints on helm release_name in the docs

This constraint exists because in our helm charts we use the release_name as part of k8s svc names, so release_name can only use characters that are valid for an individual dns label.

🚨 User Impact 🚨

better docs
no breaking changes

mention constraints on `release_name`
@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview Oct 23, 2023 10:01pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 23, 2023
@git-phu git-phu marked this pull request as ready for review October 23, 2023 22:02
@git-phu git-phu enabled auto-merge (squash) October 23, 2023 22:03
@git-phu git-phu merged commit 5f35705 into master Oct 23, 2023
20 of 21 checks passed
@git-phu git-phu deleted the git-phu-patch-2 branch October 23, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants