Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Dockerfile and .dockerignore for Java connectors #31769

Merged
merged 4 commits into from
Oct 24, 2023
Merged

remove Dockerfile and .dockerignore for Java connectors #31769

merged 4 commits into from
Oct 24, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 24, 2023 •
edited

What

Closes #30708
A clumsy merge reintroduced some java connnectors Dockerfile.
And we also forgot to remove .dockerignore files

How

Remove Dockerfile and .dockerignore files for Java connectors.
Replace airbyteDocker in README with buildConnectorImage

Java connectors docker images are 💯 built via airbyte-ci and don't require Dockerfile anymore.

@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 1:48pm

@alafanechere Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@alafanechere alafanechere marked this pull request as ready for review October 24, 2023 10:50
@alafanechere alafanechere requested review from a team as code owners October 24, 2023 10:50
@alafanechere alafanechere requested review from postamar and a team October 24, 2023 10:51
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 24, 2023 10:52
postamar
postamar requested changes Oct 24, 2023
View reviewed changes
airbyte-integrations/connectors/destination-bigquery/README.md Outdated
@@ -16,6 +16,7 @@ Note that the `secrets` directory is git-ignored by default, so there is no dang

#### Build
Build the connector image via Gradle:
You need a local install of [airbyte-ci](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md) to run this command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't. Gradle will provision a python venv and do the poetry song-and-dance to install airbyte-ci from source in the .venv folder in the repo root.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I forgot your wizardries!

@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="Deleting unused files + can't realistically run the CI on all the modified connectors"

@octavia-approvington
Copy link
Contributor

You did it!
finish line

@octavia-approvington octavia-approvington merged commit ac6f44c into master Oct 24, 2023
10 checks passed
@octavia-approvington octavia-approvington deleted the augustin/10-24-remove_Dockerfile_and_.dockerignore_for_Java_connectors branch October 24, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postamar postamar postamar approved these changes

@bazarnov bazarnov bazarnov approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/azure-blob-storage connectors/destination/bigquery connectors/destination/cassandra connectors/destination/clickhouse connectors/destination/clickhouse-strict-encrypt connectors/destination/csv connectors/destination/databricks connectors/destination/dev-null connectors/destination/doris connectors/destination/dynamodb connectors/destination/e2e-test connectors/destination/elasticsearch connectors/destination/elasticsearch-strict-encryp connectors/destination/exasol connectors/destination/gcs connectors/destination/iceberg connectors/destination/kafka connectors/destination/keen connectors/destination/kinesis connectors/destination/local-json connectors/destination/mariadb-columnstore connectors/destination/mongodb connectors/destination/mongodb-strict-encrypt connectors/destination/mqtt connectors/destination/mssql connectors/destination/mssql-strict-encrypt connectors/destination/mysql connectors/destination/mysql-strict-encrypt connectors/destination/oracle connectors/destination/oracle-strict-encrypt connectors/destination/postgres connectors/destination/postgres-strict-encrypt connectors/destination/pubsub connectors/destination/pulsar connectors/destination/r2 connectors/destination/redis connectors/destination/redpanda connectors/destination/redshift connectors/destination/rockset connectors/destination/s3-glue connectors/destination/s3 connectors/destination/scylla connectors/destination/selectdb connectors/destination/snowflake connectors/destination/starburst-galaxy connectors/destination/teradata connectors/destination/tidb connectors/destination/vertica connectors/destination/yugabytedb connectors/source/clickhouse connectors/source/clickhouse-strict-encrypt connectors/source/db2 connectors/source/dynamodb connectors/source/e2e-test connectors/source/e2e-test-cloud connectors/source/elasticsearch connectors/source/kafka connectors/source/mongodb-v2 connectors/source/mssql connectors/source/mssql-strict-encrypt connectors/source/mysql connectors/source/mysql-strict-encrypt connectors/source/oracle connectors/source/oracle-strict-encrypt connectors/source/postgres connectors/source/redshift connectors/source/sftp connectors/source/snowflake connectors/source/teradata connectors/source/tidb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove airbyteDocker and all java dockerfiles for connectors
5 participants
@alafanechere @octavia-approvington @postamar @bazarnov @octavia-squidington-iii