Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Hubspot, Source Salesforce - fix builds #31773

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

davydov-d
Copy link
Collaborator

What

Fix builds for the Source Hubspot and Source Salesforce

How

  • Update expected records

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 2:21pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d davydov-d enabled auto-merge (squash) October 24, 2023 12:42
@airbyte-oss-build-runner
Copy link
Collaborator

source-hubspot test report (commit fe8c5790a8) - ✅

⏲️ Total pipeline duration: 13mn01s

Step Result
Build source-hubspot docker image for platform(s) linux/amd64
Unit tests
Integration tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-hubspot
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@airbyte-oss-build-runner
Copy link
Collaborator

source-hubspot test report (commit e678ad7d7c) - ✅

⏲️ Total pipeline duration: 08mn37s

Step Result
Build source-hubspot docker image for platform(s) linux/amd64
Unit tests
Integration tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-hubspot
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@airbyte-oss-build-runner
Copy link
Collaborator

source-salesforce test report (commit e678ad7d7c) - ❌

⏲️ Total pipeline duration: 54mn47s

Step Result
Build source-salesforce docker image for platform(s) linux/amd64
Unit tests
Integration tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-salesforce
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-salesforce test

@airbyte-oss-build-runner
Copy link
Collaborator

source-hubspot test report (commit b106adf113) - ✅

⏲️ Total pipeline duration: 07mn50s

Step Result
Build source-hubspot docker image for platform(s) linux/amd64
Unit tests
Integration tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-hubspot
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@airbyte-oss-build-runner
Copy link
Collaborator

source-salesforce test report (commit b106adf113) - ✅

⏲️ Total pipeline duration: 26mn02s

Step Result
Build source-salesforce docker image for platform(s) linux/amd64
Unit tests
Integration tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-salesforce
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-salesforce test

@davydov-d davydov-d merged commit 38bace1 into master Oct 24, 2023
26 checks passed
@davydov-d davydov-d deleted the ddavydov/fix-hubspot-salesforce-builds branch October 24, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants