Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: check docker configuration when local exec #31774

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 24, 2023

What

Relates to #31442

airbyte-ci performance depends on the resource allocation settings of the docker engine.
We want to warn developers when their CPUs allocation is not maximized

How

Add a check in airbyte-ci command group that will:

  • Raise a click.UsageError if the docker daemon is not running
  • Log a warning if the docker daemon CPU count is lower thant the local CPU count.

We retrieve Docker CPU number with the docker python client.

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 7:49pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alafanechere alafanechere marked this pull request as ready for review October 24, 2023 12:51
@alafanechere alafanechere requested review from a team and postamar October 24, 2023 12:51
@alafanechere alafanechere enabled auto-merge (squash) October 24, 2023 12:51
@alafanechere alafanechere force-pushed the augustin/10-24-airbyte-ci_check_docker_configuration_when_local_exec branch from 63cea0b to ee12157 Compare October 24, 2023 19:49
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but perhaps warn when using less than 90% or 80% instead of when using less than 100% of CPU.

@alafanechere alafanechere merged commit 4a0465c into master Oct 25, 2023
20 checks passed
@alafanechere alafanechere deleted the augustin/10-24-airbyte-ci_check_docker_configuration_when_local_exec branch October 25, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants