Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the title of the advanced option raw_data_schema #31802

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Oct 24, 2023

From slack

This PR clarifies the title of the raw_data_schema and shows that the default value is (default: airbyte_internal). I prefer this method rather than providing an actual default value because I think it is meaningful to know if this value is present or not (e.g. the user made a change vs the config supplied the default value)

I'm not releasing these changes as new connector versions; the next release will pick them up

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Oct 24, 2023 10:07pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

destination-bigquery test report (commit 6b0c873387) - ❌

⏲️ Total pipeline duration: 10mn05s

Step Result
Build connector tar
Java Connector Unit Tests
Build destination-bigquery docker image for platform(s) linux/amd64
Java Connector Integration Tests
Validate metadata for destination-bigquery
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@evantahler
Copy link
Contributor Author

/approve-and-merge reason="copy changes for SPEC, do not want to release new connector versions"

@octavia-approvington
Copy link
Contributor

It's time
fine lets go

@octavia-approvington octavia-approvington merged commit 2014cd8 into master Oct 24, 2023
27 of 36 checks passed
@octavia-approvington octavia-approvington deleted the evan/dv2-spec-label branch October 24, 2023 22:22
@airbyte-oss-build-runner
Copy link
Collaborator

destination-snowflake test report (commit 6b0c873387) - ❌

⏲️ Total pipeline duration: 07mn56s

Step Result
Build connector tar
Java Connector Unit Tests
Build destination-snowflake docker image for platform(s) linux/amd64
Java Connector Integration Tests
Validate metadata for destination-snowflake
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao
Copy link
Contributor

edgao commented Oct 24, 2023

do connector spec updates not require publishing a new version? or do we just want to bundle this into the next release

@evantahler
Copy link
Contributor Author

They do require a publish to get to the user, but since the change was so minor, I was being lazy and just waiting for the next release... and I wantted to not cause any more version/merge conflits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants