-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the title of the advanced option raw_data_schema #31802
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
destination-bigquery test report (commit
|
Step | Result |
---|---|
Build connector tar | ✅ |
Java Connector Unit Tests | ✅ |
Build destination-bigquery docker image for platform(s) linux/amd64 | ✅ |
Java Connector Integration Tests | ✅ |
Validate metadata for destination-bigquery | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-bigquery test
/approve-and-merge reason="copy changes for SPEC, do not want to release new connector versions" |
destination-snowflake test report (commit
|
Step | Result |
---|---|
Build connector tar | ✅ |
Java Connector Unit Tests | ✅ |
Build destination-snowflake docker image for platform(s) linux/amd64 | ✅ |
Java Connector Integration Tests | ✅ |
Validate metadata for destination-snowflake | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-snowflake test
do connector spec updates not require publishing a new version? or do we just want to bundle this into the next release |
They do require a publish to get to the user, but since the change was so minor, I was being lazy and just waiting for the next release... and I wantted to not cause any more version/merge conflits. |
From slack
This PR clarifies the title of the
raw_data_schema
and shows that the default value is(default: airbyte_internal)
. I prefer this method rather than providing an actual default value because I think it is meaningful to know if this value is present or not (e.g. the user made a change vs the config supplied the default value)I'm not releasing these changes as new connector versions; the next release will pick them up