Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 source-paypal-transaction: retroactively mark 2.1.0 as a breaking change #31806

Merged
merged 5 commits into from
Oct 27, 2023
Merged

🐛 source-paypal-transaction: retroactively mark 2.1.0 as a breaking change #31806

merged 5 commits into from
Oct 27, 2023

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Oct 25, 2023 •
edited
Loading

What

@vercel
Copy link

vercel bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 5:41am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 25, 2023
@girarda girarda changed the title retroactively mark 2.0.1 as a breaking change 🐛 source-paypal-transaction: retroactively mark 2.0.1 as a breaking change Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited by girarda
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-paypal-transaction test report (commit de945dc55e) - ❌

⏲️ Total pipeline duration: 03mn13s

Step Result
Build source-paypal-transaction docker image for platform(s) linux/amd64 ✅
Acceptance tests ✅
Check our base image is used ✅
Code format checks ✅
Validate metadata for source-paypal-transaction ✅
Connector version semver check ✅
QA checks ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-paypal-transaction test

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 25, 2023
@airbyte-oss-build-runner
Copy link
Collaborator

source-paypal-transaction test report (commit 97791b2c3e) - ✅

⏲️ Total pipeline duration: 01mn43s

Step Result
Build source-paypal-transaction docker image for platform(s) linux/amd64 ✅
Acceptance tests ✅
Check our base image is used ✅
Code format checks ✅
Validate metadata for source-paypal-transaction ✅
Connector version semver check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-paypal-transaction test

erohmensing
erohmensing reviewed Oct 25, 2023
View reviewed changes
airbyte-integrations/connectors/source-paypal-transaction/metadata.yaml Outdated
Comment on lines 30 to 31
2.0.1:
message: 'Version 2.0.1 changes the format of the state. The format of the cursor changed from "2021-06-18T16:24:13+03:00" to "2021-06-18T16:24:13Z". The state key for the transactions stream changed to "transaction_updated_date" and the key for the balances stream change to "as_of_time". The upgrade is safe, but rolling back is not.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't the version 2.1.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦
yes good catch!

@girarda girarda changed the title 🐛 source-paypal-transaction: retroactively mark 2.0.1 as a breaking change 🐛 source-paypal-transaction: retroactively mark 2.1.0 as a breaking change Oct 26, 2023
@airbyte-oss-build-runner
Copy link
Collaborator

source-paypal-transaction test report (commit 6ce6b24eac) - ✅

⏲️ Total pipeline duration: 02mn33s

Step Result
Build source-paypal-transaction docker image for platform(s) linux/amd64 ✅
Acceptance tests ✅
Check our base image is used ✅
Code format checks ✅
Validate metadata for source-paypal-transaction ✅
Connector version semver check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-paypal-transaction test

@girarda girarda merged commit 30c2437 into master Oct 27, 2023
27 of 28 checks passed
@girarda girarda deleted the alex/paypal_breaking_change branch October 27, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing left review comments

@bazarnov bazarnov bazarnov approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/paypal-transaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@girarda @airbyte-oss-build-runner @erohmensing @bazarnov @octavia-squidington-iii