New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source TikTok Marketing: update metadata
, fix ads
schema duplicates
#31812
🎉 Source TikTok Marketing: update metadata
, fix ads
schema duplicates
#31812
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…arketing/update-metadata-fix-ads-schema
source-tiktok-marketing test report (commit
|
Step | Result |
---|---|
Build source-tiktok-marketing docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ✅ |
Validate metadata for source-tiktok-marketing | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-tiktok-marketing test
What
metadata.yaml
with:tracking_pixel_id: type "number"
duplicated field fromads
stream schema.How
metadata.yaml
ads
stream schema🚨 User Impact 🚨
No impact is expected, since removing the field in this case will not affect the Customers, because the
tracking_pixel_id
field is picked up with the rightinteger
data-type.