Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source TikTok Marketing: update metadata, fix ads schema duplicates #31812

Merged

Conversation

bazarnov
Copy link
Collaborator

What

  1. We need to update the metadata.yaml with:
  • suggested streams
  • sl: 300
  1. remove the duplicated tracking_pixel_id: type "number" duplicated field from ads stream schema.

How

  • updated metadata.yaml
  • updated ads stream schema

🚨 User Impact 🚨

No impact is expected, since removing the field in this case will not affect the Customers, because the tracking_pixel_id field is picked up with the right integer data-type.

@bazarnov bazarnov self-assigned this Oct 25, 2023
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 10:41am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 25, 2023
@bazarnov bazarnov marked this pull request as ready for review October 25, 2023 10:31
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 25, 2023 10:32
@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 6fbb9bab31) - ✅

⏲️ Total pipeline duration: 51mn45s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/amd64
Unit tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@bazarnov bazarnov merged commit 978a37e into master Oct 25, 2023
27 checks passed
@bazarnov bazarnov deleted the baz/source-tiktok-marketing/update-metadata-fix-ads-schema branch October 25, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/tiktok-marketing
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

5 participants