🐛 Source Jira - better handling of invalid domain in check

[pedroslopez]

What

We've gotten paged a couple times due to an unhandled exception raised when a user inputs an invalid domain while configuring Jira. Specifically, this happens when the user inputs the domain with protocol (e.g. https://airbyte.atlassian.net rather than the expected airbyte.atlassian.net).

Previously invalid domains were attempted to be handled as a config error, but there's an edge case in there with how invalid urls are handled and raised.

(see sentry issue)

How

Fix by checking if response is None before accessing any fields in it. Also, handle the InvalidURL error so it raises the same config error. The messging for the error has also been tweaked to hint at protocol inclusion.

Then, updated any tests as needed.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 26, 2023 10:59pm

[pedroslopez]

Current dependencies on/for this PR:

• master
  • PR 🐛 Source Jira - better handling of invalid domain in check #31896 👈

This comment was auto-generated by Graphite.

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.