Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination snowflake: filter raw table commit on extracted_at #31897

Merged
merged 6 commits into from Oct 27, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Oct 26, 2023

I apparently forgot to actually use the extracted_at condition anywhere in this query >.>

(the insert statement does use the condition correctly though)

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 27, 2023 5:01pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 26, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao marked this pull request as ready for review October 26, 2023 22:53
@edgao edgao requested a review from a team as a code owner October 26, 2023 22:53
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved... but... shouldn't there have been a test that failed that would have caught this?

@edgao
Copy link
Contributor Author

edgao commented Oct 27, 2023

good point. will check on that tomorrow 🤔

@edgao
Copy link
Contributor Author

edgao commented Oct 27, 2023

ugh. apparently I only had tests to verify that we fetched the min timestamp correctly. Added a new test to verify that min timestamp can filter out unloaded records.

(which isn't a thing that should happen during a real sync, but we might as well verify it)

@edgao edgao merged commit 877200d into master Oct 27, 2023
21 of 22 checks passed
@edgao edgao deleted the edgao/snowflake/extracted_at_filtering branch October 27, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants