New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination snowflake: filter raw table commit on extracted_at #31897
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved... but... shouldn't there have been a test that failed that would have caught this?
good point. will check on that tomorrow 🤔 |
ugh. apparently I only had tests to verify that we fetched the min timestamp correctly. Added a new test to verify that min timestamp can filter out unloaded records. (which isn't a thing that should happen during a real sync, but we might as well verify it) |
I apparently forgot to actually use the extracted_at condition anywhere in this query >.>
(the insert statement does use the condition correctly though)