Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source google ads: migrate to python based image #31908

Merged
merged 7 commits into from Oct 27, 2023

Conversation

davydov-d
Copy link
Collaborator

What

Fix build for the Google Ads Source Connector

How

Migrate to python based image

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 27, 2023 0:10am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads labels Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@alafanechere
Copy link
Contributor

@davydov-d the failling acceptance test is related to this issue:
#31808

We'll try to fix it asap

@davydov-d
Copy link
Collaborator Author

@davydov-d the failling acceptance test is related to this issue: #31808

We'll try to fix it asap

thanks @alafanechere ! however I think this is not the root cause. The output is usually that big when we have mismatch between actual and expected records

@alafanechere
Copy link
Contributor

@davydov-d the failling acceptance test is related to this issue: #31808

We'll try to fix it asap

thanks @alafanechere ! however I think this is not the root cause. The output is usually that big when we have mismatch between actual and expected records

Your experience speaks for itself! But it'd be great to actually see the error 🙂

@davydov-d davydov-d enabled auto-merge (squash) October 27, 2023 12:23
@davydov-d davydov-d merged commit 9c0dca5 into master Oct 27, 2023
21 of 22 checks passed
@davydov-d davydov-d deleted the ddavydov/source-google-ads-fix-build branch October 27, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants