Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Typeform: Fix pagination for Responses stream #31914

Merged
merged 3 commits into from Oct 27, 2023

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Oct 27, 2023

What

Fix pagination for the Responses stream.
Closes: https://github.com/airbytehq/oncall/issues/3386

How

Change pagination for the Responses stream from unsupported page increment to cursor-based according to Typeform documentation.

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 0:45am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@tolik0 tolik0 marked this pull request as ready for review October 27, 2023 11:58
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 27, 2023
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 27, 2023 12:00
@tolik0 tolik0 merged commit b8d65c2 into master Oct 27, 2023
27 checks passed
@tolik0 tolik0 deleted the tolik0/source-typeform/fix-responses-pagination branch October 27, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/typeform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants