Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Mailchimp: Add Segments stream #31922

Merged
merged 15 commits into from Oct 30, 2023

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Oct 27, 2023

What

Add the Segments stream to Source Mailchimp
Mailchimp Docs link

How

  • Each stream slice consists of a parent list
  • Date filter is passed as a request_param using the value of state for the current parent list. If none exists, no filter is used and all records are read.
  • Each list has its own state value, ie
{ 
  list_id_1: {"last_updated": <timestamp>}, 
  list_id_2: {"last_updated": <timestamp>}
}

User Impact

Not a breaking change.

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 2:48pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@ChristoGrab ChristoGrab marked this pull request as ready for review October 27, 2023 15:38
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 27, 2023 15:39
@pytest.mark.parametrize(
"stream_slice,stream_state,next_page_token,expected_params",
[
# Test case 1: no state, no next_page_token
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use ids parameter to increase readability of parametrized tests (see example here)

@ChristoGrab ChristoGrab merged commit 521f854 into master Oct 30, 2023
25 checks passed
@ChristoGrab ChristoGrab deleted the christo/mailchimp-segments-stream branch October 30, 2023 15:08
jbfbell pushed a commit that referenced this pull request Oct 30, 2023
Co-authored-by: ChristoGrab <ChristoGrab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailchimp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants