Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Zenefits : Migrate Python CDK to Low-code CDK #31946

Merged

Conversation

pabloescoder
Copy link
Collaborator

What

Migrate Zenefits Python CDK to Low-code CDK resolves #30889

How

Low Code CDK & Connector Builder

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 5:30pm

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm
Copy link
Member

@pabloescoder can you share integration test output? It's not working on my side.

@pabloescoder
Copy link
Collaborator Author

@marcosmarxm Sure, I'll need credentials so that I can run the integration test, I'll DM you on Slack for the same.

@pabloescoder
Copy link
Collaborator Author

Hey @marcosmarxm I found the mistake, I was looking for the api_key field in the config and it should've been token instead. Also, a few fields were missing in the schema files for employments, people, and vacation_types. So I added them as well.
All the integration tests pass now and the connector should work as expected. Attaching the integration test report zenefits-integration-tests.txt

@marcosmarxm marcosmarxm merged commit db625c9 into airbytehq:master Oct 31, 2023
37 of 46 checks passed
@marcosmarxm marcosmarxm added the low-code-migration This connector has been migrated to the low-code CDK label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/zenefits hackathon-2023-10 low-code-migration This connector has been migrated to the low-code CDK
Projects
Development

Successfully merging this pull request may close these issues.

✨ Source Zenefits : Migrate Python CDK to Low-code CDK
3 participants