New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨🚨🐛 Source Mixapanel: Delete default primary key for Export stream #31955
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
In this release, the default primary key for stream Export has been deleted, | ||
allowing users to select the key that best fits their data. | ||
Users will need to refresh the source schema and reset | ||
affected streams after upgrading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ["distinct_id", "event", "time"] fits their usecase do they still need to refresh/reset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing that out! Upon local testing, it was found that after upgrading, users have the option to change the primary key, and the previous fields remain selected. Therefore, a refresh is only necessary if there's a need to apply a new primary key. I've updated the relevant messages to reflect this.
a31f8ce
to
5de60b7
Compare
What
Removed the default primary key from the
Export
stream.How
The columns recommended by Mixpanel for the primary key -
[insert_id, event_time, event_name, distinct_id]
- may not always have aninsert_id
for certain users. This issue is discussed in detail here. This PR aims to give users the flexibility to choose their primary key, as requested in this related PR.🚨 User Impact 🚨
This PR introduces breaking changes due to the removal of the default primary key for the
Export
stream.