Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: fix pip / cdk caching #31974

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 30, 2023

What

Closes #31793

We want to install the freshest CDK version on connectors that are not pinning their CDK version.
But the current approach was not valid because:

How

  • On connector build: always install the latest CDK, guaranteed by a cachebuster env var and a --force-reinstall
  • Mount pip and poetry cache during image build
  • Write a test to make sure the airbyte-cdk is correctly installed from the cache

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 8:46am

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere marked this pull request as ready for review October 30, 2023 18:12
@alafanechere alafanechere requested a review from a team October 30, 2023 18:12
@alafanechere alafanechere force-pushed the augustin/10-30-airbyte-ci_fix_pip_/_cdk_caching branch from aec217d to 031f613 Compare October 31, 2023 08:46
@alafanechere alafanechere enabled auto-merge (squash) October 31, 2023 08:46
@alafanechere alafanechere merged commit df98303 into master Oct 31, 2023
19 checks passed
@alafanechere alafanechere deleted the augustin/10-30-airbyte-ci_fix_pip_/_cdk_caching branch October 31, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate pip install race condition between cdk publish and connector publish
2 participants