Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java CDK, source-postgres: speed up tests involving debezium #31976

Merged
merged 17 commits into from
Oct 31, 2023
Merged

java CDK, source-postgres: speed up tests involving debezium #31976

merged 17 commits into from
Oct 31, 2023

Conversation

postamar
Copy link
Contributor

This PR includes three meaningful, distinct changes which each improve test execution latency when relying on the Debezium engine. These changes aim to have limited impact in a production setting.

Fixes #31828.

@postamar postamar requested a review from a team as a code owner October 30, 2023 19:02
@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 2:55pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit labels Oct 30, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 30, 2023 19:03
@postamar postamar removed the request for review from a team October 30, 2023 19:13
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 30, 2023 19:17
@postamar postamar removed the request for review from a team October 30, 2023 20:01
rodireich
rodireich reviewed Oct 30, 2023
View reviewed changes
...es/src/main/java/io/airbyte/integrations/source/postgres/cdc/PostgresCdcCtidInitializer.java
@@ -167,6 +167,8 @@ public static List<AutoCloseableIterator<AirbyteMessage>> cdcCtidIteratorsCombin
final PostgresCdcStateHandler postgresCdcStateHandler = new PostgresCdcStateHandler(stateManager);

final boolean canShortCircuitDebeziumEngine = savedOffset.isPresent() &&
// Until the need presents itself in production, short-circuiting should only be done in tests.
sourceConfig.has("is_test") && sourceConfig.get("is_test").asBoolean() &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 30, 2023 20:03
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 31, 2023
@postamar
Copy link
Contributor Author

postamar commented Oct 31, 2023 •
edited by github-actions bot
Loading

/publish-java-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/6707976664
❌ Publish Java CDK version=0.2.1 failed!

@postamar postamar force-pushed the postamar/dbz-postgres-test-speedup branch from 0c9d758 to 9356a6b Compare October 31, 2023 14:54
@postamar
Copy link
Contributor Author

Hmm, seems like CDK version 0.2.1 has already been published. Bumping to 0.2.2.

@postamar postamar force-pushed the postamar/dbz-postgres-test-speedup branch from 9356a6b to 4e4041e Compare October 31, 2023 14:55
@postamar
Copy link
Contributor Author

postamar commented Oct 31, 2023 •
edited by github-actions bot
Loading

/publish-java-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/6708323117
✅ Successfully published Java CDK version=0.2.2!

@postamar
Copy link
Contributor Author

postamar commented Oct 31, 2023 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6708589730
✅ Successfully published Java CDK version=0.2.2!

@postamar postamar merged commit bc78d21 into master Oct 31, 2023
23 of 26 checks passed
@postamar postamar deleted the postamar/dbz-postgres-test-speedup branch October 31, 2023 16:04
@postamar
Copy link
Contributor Author

Thanks for the review!

@postamar postamar mentioned this pull request Nov 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodireich rodireich rodireich approved these changes

@subodh1810 subodh1810 Awaiting requested review from subodh1810

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java CDK: make DebeziumRecordIterator less time-sensitive in tests
4 participants
@postamar @rodireich @octavia-squidington-iii @alafanechere