Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaviate: Add retry #32038

Merged
merged 8 commits into from Nov 2, 2023
Merged

Weaviate: Add retry #32038

merged 8 commits into from Nov 2, 2023

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Nov 1, 2023

Fixes #31991

The Weaviate client is already retrying requests automatically in situations like timeouts. However, some situations like in the linked issue are not handled by this default setting.

This PR is enabling retries for all errors on the Weaviate client to improve this issue.

@flash1293 flash1293 requested a review from a team as a code owner November 1, 2023 10:50
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 3:57pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/weaviate labels Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks! 👍 🚢

@flash1293 flash1293 merged commit 402ac60 into master Nov 2, 2023
23 checks passed
@flash1293 flash1293 deleted the flash1293/weaviate-retry branch November 2, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/weaviate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destination Weaviate: update vector: connection to: OpenAI API failed with status: 500 error
3 participants