Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: never cache docker login #32090

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Nov 2, 2023

What

I believe the recent rate limiting issues on docker pull described in #32089 might be caused by caching of the docker login command.

How

  • Add a cachebuster env var before the docker login operation.

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 10:47am

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere marked this pull request as ready for review November 2, 2023 10:50
@alafanechere alafanechere requested a review from a team November 2, 2023 10:50
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! Yes, I think that's it.

@postamar
Copy link
Contributor

postamar commented Nov 2, 2023

Ironically the CAT unit tests are failing with

 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: 

@postamar postamar enabled auto-merge (squash) November 2, 2023 13:03
@postamar postamar merged commit a6e2e34 into master Nov 2, 2023
24 checks passed
@postamar postamar deleted the augustin/11-02-airbyte-ci_never_cache_docker_login branch November 2, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants