Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination bigquery: reduce commit frequency in GCS staging mode #32112

Merged
merged 17 commits into from Nov 7, 2023
Merged

Destination bigquery: reduce commit frequency in GCS staging mode #32112

merged 17 commits into from Nov 7, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Nov 2, 2023 •
edited

more context in https://airbytehq-team.slack.com/archives/C05H8UCNCK0/p1698964771455149?thread_ts=1698939985.620589&cid=C05H8UCNCK0 and https://github.com/airbytehq/oncall/issues/3468

I did some manual tests with source-faker and source-postgres. In both cases, this resulted in less-frequent flushes without affecting memory usage. (admittedly these were both one-stream syncs :/ but my understanding is that the async framework is supposed to detect memory pressure anyway, so.... 🤷)

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 9:55pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/bigquery labels Nov 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Nov 2, 2023
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Nov 2, 2023
@edgao edgao changed the title edgao test Destination bigquery: reduce commit frequency in GCS staging mode Nov 2, 2023
@edgao edgao marked this pull request as ready for review November 2, 2023 23:12
@edgao edgao requested a review from a team as a code owner November 2, 2023 23:12
evantahler
evantahler approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks to all the testing, and the change to 200mb files makes sense.

I think this is a slow-rollout scenario - goes this also work well with wide datasets, many streams, etc. It's probably OK, but please make a dev image and test in some (our?) workspace first.

airbyte-integrations/connectors/destination-bigquery/build.gradle Outdated
useLocalCdk = false
useLocalCdk = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to revert this

@edgao
Copy link
Contributor Author

edgao commented Nov 6, 2023

sounds good. I'll do our workspace + the workspace in https://github.com/airbytehq/oncall/issues/3468

@edgao
Copy link
Contributor Author

edgao commented Nov 6, 2023

LD rule updated https://airbytehq-team.slack.com/archives/C045LB3JW3W/p1699294622364549

@edgao edgao mentioned this pull request Nov 7, 2023
Closed
@edgao
Copy link
Contributor Author

edgao commented Nov 7, 2023

this has been running stably for the last day. releasing cdk + merging.

@edgao
Copy link
Contributor Author

edgao commented Nov 7, 2023 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6789125300
❌ Publish Java CDK version=0.4.5 failed!

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 7, 2023
@edgao
Copy link
Contributor Author

edgao commented Nov 7, 2023 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6789450497
✅ Successfully published Java CDK version=0.4.5!

@edgao edgao dismissed benmoriceau’s stale review November 7, 2023 19:55

comment was addressed + reviewer is pto

@edgao edgao enabled auto-merge (squash) November 7, 2023 21:53
@edgao edgao merged commit 37172c1 into master Nov 7, 2023
21 of 22 checks passed
@edgao edgao deleted the edgao/test branch November 7, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tryangul tryangul tryangul left review comments

@evantahler evantahler evantahler approved these changes

@benmoriceau benmoriceau Awaiting requested review from benmoriceau

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@edgao @evantahler @benmoriceau @tryangul @octavia-squidington-iii