New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 📝 re-update all connectors for new CDK version and more stringent javac checks #32125
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed myself as a blocker spinning off the connector changes in #32050 into separate PRs:
#32173
#32174
#32175
#32176
#32177
#32178
#32179
#32180
Not all have release notes, because the CDK bump is often a functional no-op.
Please feel free to do whatever suits you best with these. I set them to auto-merge before signing off.
0bd4cfe
to
f86dc09
Compare
c1bdfa7
to
4601fea
Compare
Coverage report for source-postgres
|
…hecks This reverts commit 9c6ed93.
9c5aab5
to
c442ad3
Compare
This is a no-op in term of features or bugs. This is part 2 of a series of PRs. This builds upon #32118
I'm only trying to use as many compiler warnings as possible. They're cheap and can help with a lot of bugs.
Unfortunately, until very recently, our CDK was packaged in a way that causes warnings in any package that used it. I fixed that in 0.4.0 but all projects that use local CDK will have a warning, which means we can't turn those into errors.
Since we released a new CDK (0.4.0) that exports everything properly, we now need to use it and fix the connectors that are certified