🐛 📝 re-update all connectors for new CDK version and more stringent javac checks by stephane-airbyte · Pull Request #32125 · airbytehq/airbyte

Stephane Geneix (stephane-airbyte) · 2023-11-02T23:30:18Z

This is a no-op in term of features or bugs. This is part 2 of a series of PRs. This builds upon #32118

I'm only trying to use as many compiler warnings as possible. They're cheap and can help with a lot of bugs.
Unfortunately, until very recently, our CDK was packaged in a way that causes warnings in any package that used it. I fixed that in 0.4.0 but all projects that use local CDK will have a warning, which means we can't turn those into errors.

Since we released a new CDK (0.4.0) that exports everything properly, we now need to use it and fix the connectors that are certified

vercel · 2023-11-02T23:30:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Nov 8, 2023 9:02pm

CLAassistant · 2023-11-02T23:30:24Z

All committers have signed the CLA.

github-actions · 2023-11-02T23:30:37Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Stephane Geneix (stephane-airbyte) · 2023-11-02T23:46:19Z


                                                 More details:
-                                                   """;
+                                                 """;


fixing whitespace that would be removed by the compiler but triggered a warning

Stephane Geneix (stephane-airbyte) · 2023-11-02T23:46:36Z


 @Slf4j
+@SuppressWarnings("try")
 public class BigQueryRecordStandardConsumer extends AsyncStreamConsumer {


close throws Exception, hence the suppresswarnings

Stephane Geneix (stephane-airbyte) · 2023-11-02T23:46:52Z

 */
-public class BigQueryRecordConsumer extends FailureTrackingAirbyteMessageConsumer implements AirbyteMessageConsumer {
+@SuppressWarnings("try")
+class BigQueryRecordConsumer extends FailureTrackingAirbyteMessageConsumer implements AirbyteMessageConsumer {


close() throws Exception, hence the SuppressWarnings

Stephane Geneix (stephane-airbyte) · 2023-11-02T23:47:14Z


  @Override
+  @Deprecated
  public void cleanUpStage(final String datasetId, final String stream, final List<String> stagedFiles) {


the overloaded cleanUpStage is deprecated,so this one needs to be annotated too

Rodi Reich Zilberman (rodireich)

0 warnings!
Looks good to me.

Maybe just consult with @airbytehq/destinations since a bunch of their connectors are upgraded as well.

Marius Posta (postamar)

Can you wait until #32050 merges please? I expect it to pass CI in an hour or so, since it touches quite a few of the same connectors. It bumps them to 0.4.0 as well.

Blocking the merge is the only reason why I'm "requesting changes"

edit: incidentally, my PR fixes the destination-s3 build

Marius Posta (postamar) · 2023-11-03T18:05:55Z


 | Version         | Date       | Pull Request                                               | Subject                                                                                                                                                         |
 |:----------------|:-----------|:-----------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 3.4.6           | 2023-11-03 | [32125](https://github.com/airbytehq/airbyte/pull/32125)   | Fix compilation warnings 7                                                                                                                                 |


Marius Posta (postamar) · 2023-11-03T18:08:47Z


 | Version | Date       | Pull Request                                               | Subject                                                                                                                                                         |
 |:--------|:-----------|:-----------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 2.3.6   | 2023-11-03 | [32125](https://github.com/airbytehq/airbyte/pull/32125)   | fix compilation warnings                                                                                                                                         |


nit: here and in the other changelogs, I think the significant change is rather that we're adopting version 0.4.0 of the CDK.

I'm assuming that these changelogs are read when the connector's misbehaving after an upgrade; knowing about the CDK change is probably going to be more relevant in that use case.

Marius Posta (postamar)

I've removed myself as a blocker spinning off the connector changes in #32050 into separate PRs:
#32173
#32174
#32175
#32176
#32177
#32178
#32179
#32180

Not all have release notes, because the CDK bump is often a functional no-op.

Please feel free to do whatever suits you best with these. I set them to auto-merge before signing off.

github-actions · 2023-11-08T18:27:08Z

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage	72.03%	🍏

…hecks This reverts commit 9c6ed93.

Octavia Squidington III (octavia-squidington-iii) added the area/connectors Connector related issues label Nov 2, 2023

Stephane Geneix (stephane-airbyte) commented Nov 2, 2023

View reviewed changes

Stephane Geneix (stephane-airbyte) requested a review from Rodi Reich Zilberman (rodireich) November 2, 2023 23:47

Stephane Geneix (stephane-airbyte) removed connectors/destination/azure-blob-storage connectors/destination/cassandra connectors/destination/clickhouse connectors/destination/csv connectors/source/clickhouse connectors/source/cockroachdb labels Nov 2, 2023

Rodi Reich Zilberman (rodireich) approved these changes Nov 3, 2023

View reviewed changes

Marius Posta (postamar) suggested changes Nov 3, 2023

View reviewed changes

Marius Posta (postamar) approved these changes Nov 3, 2023

View reviewed changes

Marius Posta (postamar) approved these changes Nov 6, 2023

View reviewed changes

Stephane Geneix (stephane-airbyte) added 14 commits November 8, 2023 12:59

rupdate all connectors for new CDK version and more stringent javac c…

cd091a3

…hecks This reverts commit 9c6ed93.

revert changes to community connectors

29d19b1

update all certified java connectors to cdk 0.4.0

53e4699

push new connector versions

6babc85

really push new connector versions

f27c789

fix

f10684f

fix

f5d9af0

fix

8f6c03a

fix doc

98b461f

fix docs

a327cb1

fix doc

0a49802

bump destination-snowflake version

a83b77a

fix doc

c442ad3

fix destination-bigquery version

758f85e

Navigation Menu

Repository navigation

🐛 📝 re-update all connectors for new CDK version and more stringent javac checks - #32125

🐛 📝 re-update all connectors for new CDK version and more stringent javac checks#32125
Stephane Geneix (stephane-airbyte) merged 14 commits into
masterfrom
stephane-compiler-checks-2

Stephane Geneix (stephane-airbyte) commented Nov 2, 2023 •

edited

Loading

Uh oh!

vercel Bot commented Nov 2, 2023 •

edited

Loading

Uh oh!

CLAassistant commented Nov 2, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 2, 2023 •

edited by stephane-airbyte

Loading

Uh oh!

Stephane Geneix (stephane-airbyte) Nov 2, 2023

Uh oh!

Stephane Geneix (stephane-airbyte) Nov 2, 2023

Uh oh!

Stephane Geneix (stephane-airbyte) Nov 2, 2023

Uh oh!

Stephane Geneix (stephane-airbyte) Nov 2, 2023

Uh oh!

Rodi Reich Zilberman (rodireich) left a comment

Uh oh!

Marius Posta (postamar) left a comment •

edited

Loading

Uh oh!

Marius Posta (postamar) Nov 3, 2023

Uh oh!

Marius Posta (postamar) Nov 3, 2023

Uh oh!

Marius Posta (postamar) left a comment •

edited

Loading

Uh oh!

github-actions Bot commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Stephane Geneix (stephane-airbyte) commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2023 • edited by stephane-airbyte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before Merging a Connector Pull Request

Uh oh!

Stephane Geneix (stephane-airbyte) Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

Stephane Geneix (stephane-airbyte) Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

Stephane Geneix (stephane-airbyte) Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

Stephane Geneix (stephane-airbyte) Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

Rodi Reich Zilberman (rodireich) left a comment

Choose a reason for hiding this comment

Uh oh!

Marius Posta (postamar) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marius Posta (postamar) Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

Marius Posta (postamar) Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

Marius Posta (postamar) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 8, 2023

Coverage report for source-postgres

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Stephane Geneix (stephane-airbyte) commented Nov 2, 2023 •

edited

Loading

vercel Bot commented Nov 2, 2023 •

edited

Loading

CLAassistant commented Nov 2, 2023 •

edited

Loading

github-actions Bot commented Nov 2, 2023 •

edited by stephane-airbyte

Loading

Marius Posta (postamar) left a comment •

edited

Loading

Marius Posta (postamar) left a comment •

edited

Loading