Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 📝 re-update all connectors for new CDK version and more stringent javac checks #32125

Merged
merged 14 commits into from Nov 8, 2023

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Nov 2, 2023

This is a no-op in term of features or bugs. This is part 2 of a series of PRs. This builds upon #32118

I'm only trying to use as many compiler warnings as possible. They're cheap and can help with a lot of bugs.
Unfortunately, until very recently, our CDK was packaged in a way that causes warnings in any package that used it. I fixed that in 0.4.0 but all projects that use local CDK will have a warning, which means we can't turn those into errors.

Since we released a new CDK (0.4.0) that exports everything properly, we now need to use it and fix the connectors that are certified

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:02pm

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed myself as a blocker spinning off the connector changes in #32050 into separate PRs:
#32173
#32174
#32175
#32176
#32177
#32178
#32179
#32180

Not all have release notes, because the CDK bump is often a functional no-op.

Please feel free to do whatever suits you best with these. I set them to auto-merge before signing off.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 72.03% 🍏

@stephane-airbyte stephane-airbyte merged commit 49043b5 into master Nov 8, 2023
29 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane-compiler-checks-2 branch November 8, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants