Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Recharge: reduce period in days for subsciptions stream to avoid 504 - Gateway Timeout error #32132

Merged
merged 8 commits into from Nov 3, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Nov 3, 2023

What

Resolving: https://github.com/airbytehq/oncall/issues/3424

How

  • changed the period_in_months > period_in_days with default value of 30 days.
  • overridden the period_in_days value for subscriptions stream to be 14 days (half of the default value)

🚨 User Impact 🚨

No impact is expected.

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 1:01pm

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 3, 2023
@bazarnov bazarnov marked this pull request as ready for review November 3, 2023 10:31
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 3, 2023 10:33
@bazarnov bazarnov merged commit 9974135 into master Nov 3, 2023
25 checks passed
@bazarnov bazarnov deleted the baz/source-recharge/fix-504 branch November 3, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/recharge team/connectors-python
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants