Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: enable unit tests coverage #32139

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Nov 3, 2023

What

Closes #31928
Connector developers want unit test coverage metrics for the certification process

How

  • Install pytest-cov in all python connector test environments
  • Fail the unit test for certified connectors if their coverage < 90%

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 6:10pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere force-pushed the augustin/11-03-source-google-sheets_enable_test_coverage_computation branch from 02e3f9a to eb07b8f Compare November 3, 2023 14:27
@alafanechere alafanechere marked this pull request as ready for review November 3, 2023 14:27
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will we see this automatically along with some other commands, like build or test or there is a dedicated command to check the coverage? (not obvious form the code)

@alafanechere
Copy link
Contributor Author

@bazarnov this will be displayed in the unit test logs in the report when running airbyte-ci connectors test locally and in the CI.

@alafanechere alafanechere merged commit dc36490 into master Nov 3, 2023
21 checks passed
@alafanechere alafanechere deleted the augustin/11-03-source-google-sheets_enable_test_coverage_computation branch November 3, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airbyte-ci: python unit test coverage should be shown on test output
2 participants