Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Instagram: Add INTERNAL_SERVER_ERROR to retriable errors #32200

Merged
merged 6 commits into from Nov 10, 2023

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Nov 6, 2023

What

This update enhances the connector's resilience by treating INTERNAL_SERVER_ERROR responses as transient issues that can be retried. Closes:

How

The backoff strategy has been updated to include HTTP status codes 500 (Internal Server Error). This change means that when the connector encounters these errors, it will automatically attempt to resend the request after a brief delay, improving the chances of a successful connection without manual intervention.

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2023 0:47am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 6, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 7, 2023
@tolik0 tolik0 marked this pull request as ready for review November 8, 2023 13:00
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 8, 2023 13:01
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 10, 2023 00:48
@tolik0 tolik0 merged commit 4677cd7 into master Nov 10, 2023
24 of 25 checks passed
@tolik0 tolik0 deleted the ryermilov/source-instagram-add-retriable-errors branch November 10, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants