Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Mailchimp: Add expected records #32226

Merged
merged 18 commits into from
Nov 14, 2023
Merged

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Nov 6, 2023

What

Currently, we are reading from our internal Mailchimp account for CAT tests, so expected_records can't be populated in order to avoid sharing internal data. We do have an old sandbox account that has now been reactivated and can be safely used for testing purposes.

How

  • Added expected_records for all streams other than Automations (need to upgrade to paid account to populate stream)
  • Updated credentials in GSM
  • Added missing enum value for type property in Campaigns stream
  • In edge cases where a campaign has not yet received any clicks, the Reports stream returns an empty string for clicks.last_click property. This causes validation errors due to the declared date-time format. Added logic to exclude the property if it is an empty string.

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 7:01pm

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@ChristoGrab ChristoGrab marked this pull request as ready for review November 7, 2023 15:02
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Minor comments left

docs/integrations/sources/mailchimp.md Outdated Show resolved Hide resolved
ChristoGrab and others added 2 commits November 10, 2023 09:21
…imp/streams.py

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>
Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>
@ChristoGrab ChristoGrab linked an issue Nov 10, 2023 that may be closed by this pull request
@ChristoGrab ChristoGrab removed the request for review from a team November 10, 2023 15:05
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice! I confirm that the expected records don't have PII (we made some fake test accounts)

@ChristoGrab ChristoGrab merged commit d53dcb4 into master Nov 14, 2023
24 checks passed
@ChristoGrab ChristoGrab deleted the christo/mailchimp-sandbox branch November 14, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailchimp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Mailchimp bypasses expected_records tests
5 participants