Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰Source Instagram: skip reading MediaInsights if error code 10 received #32245

Merged
merged 4 commits into from Nov 13, 2023

Conversation

askarpets
Copy link
Contributor

What

Do not raise FacebookRequestError with code of 10 while reading MediaInsights stream
https://github.com/airbytehq/oncall/issues/2844

How

Skip reading MediaInsights stream if FacebookRequestError received with code of 10 and error message "(#10) Application does not have permission for this action"

Recommended reading order

  1. streams.py
  2. test_streams.py

馃毃 User Impact 馃毃

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@askarpets askarpets self-assigned this Nov 7, 2023
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview Nov 10, 2023 0:23am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@tolik0 tolik0 force-pushed the source-instagram-media-insights-handle-error-10 branch from 89f653c to d3b4f45 Compare November 10, 2023 12:21
@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/source/appfollow labels Nov 10, 2023
@tolik0 tolik0 marked this pull request as ready for review November 10, 2023 12:23
@tolik0 tolik0 requested a review from a team November 10, 2023 12:24
@tolik0 tolik0 merged commit 87f51fa into master Nov 13, 2023
27 of 30 checks passed
@tolik0 tolik0 deleted the source-instagram-media-insights-handle-error-10 branch November 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/appfollow connectors/source/instagram
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants