Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updates Salesforce Source Connector Docs (Removes inapp page, adds <HideInUI>, adds Limitations & Troubleshooting) #32371

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Nov 9, 2023

What

Updates for Salesforce source connector docs pages. This update includes addition of new collapsible troubleshooting section, as well as the replacement of the "inapp" docs with the new tags per Issue #32069.

How

  • Removed in-app page
  • Added HideInUI tags to all sections other than Prerequisites and Setup Guide.
  • env tags handle sections to be displayed only in OSS vs Cloud pages.
  • Added Limitations & Troubleshooting section, per new suggested approach.

Main page vs In-app OSS (Example)

Shopify docs difference

Limitations & Troubleshooting Section (Example)

Limitations screenshot

…itations & Troubleshooting section. Added env and HideInUI tags for dynamically rendering content.
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 11:39pm

@@ -132,20 +166,28 @@ Salesforce allows extracting data using either the [BULK API](https://developer.

More information on the differences between various Salesforce APIs can be found [here](https://help.salesforce.com/s/articleView?id=sf.integrate_what_is_api.htm&type=5).

:::info Force Using Bulk API
:::note Force Using Bulk API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is rendering weirdly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is rendering weirdly

@katmarkham Is this happening via Docusaurus or in the markdown preview in GitHub? These are Docusaurus admonitions so I don't think they'll render in GitHub markdown.

This is what I see when running Docusaurus locally:

Screenshot 2023-11-10 at 10 40 48 AM


Salesforce allows extracting data using either the [BULK API](https://developer.salesforce.com/docs/atlas.en-us.236.0.api_asynch.meta/api_asynch/asynch_api_intro.htm) or [REST API](https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/intro_what_is_rest_api.htm). To achieve fast performance, Salesforce recommends using the BULK API for extracting larger amounts of data (more than 2,000 records). For this reason, the Salesforce connector uses the BULK API by default to extract any Salesforce objects, unless any of the following conditions are met:

- The Salesforce object has columns which are unsupported by the BULK API, like columns with a `base64` or `complexvalue` type
- The Salesforce object is not supported by BULK API. In this case we sync the objects via the REST API which will occasionalyl cost more of your API quota. This list of objects was obtained experimentally, and includes the following objects:
- The Salesforce object is not supported by BULK API. In this case we sync the objects via the REST API which will occasionalyl cost more of your API quota. This list of objects was obtained experimentally, and includes the following objects:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*occasionally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. Updated.

@pnilan pnilan merged commit 1375957 into master Jan 4, 2024
19 checks passed
@pnilan pnilan deleted the pnilan/salesforce-docs-fix branch January 4, 2024 23:41
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants