Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java CDK: skip dropping database in PostgresTestDatabase::close #32377

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Nov 9, 2023

This PR follows up on #32314
I profiled some tests and noticed that we spent an stupendous amount of time closing the PostgresTestDatabase instances. As it turns out, DROP DATABASE is really slow. We don't need to do it so let's not.

This PR also gets rid of the tmpDir because it's not actually needed.

@postamar postamar requested a review from a team as a code owner November 9, 2023 18:59
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 7:27pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/postgres labels Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 71.75% 🍏

@postamar
Copy link
Contributor Author

postamar commented Nov 9, 2023

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6816344297
✅ Successfully published Java CDK version=0.4.8!

@postamar postamar enabled auto-merge (squash) November 9, 2023 19:28
@postamar
Copy link
Contributor Author

postamar commented Nov 9, 2023

/approve-and-merge reason="docker pull rate limit"

@octavia-approvington
Copy link
Contributor

A job well done
nice job

@octavia-approvington octavia-approvington merged commit f604110 into master Nov 9, 2023
16 of 20 checks passed
@octavia-approvington octavia-approvington deleted the postamar/try-not-tearing-down-anything branch November 9, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/source/postgres
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants