Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Bing Ads: normalize numeric values #32422

Merged
merged 14 commits into from Nov 14, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Nov 10, 2023

What

Resolve https://github.com/airbytehq/oncall/issues/3503

How

Normalize numeric values

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:42pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 10, 2023
Copy link
Contributor

github-actions bot commented Nov 10, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 changed the title Source Bing Ads: normalize numeric values 🐛 Source Bing Ads: normalize numeric values Nov 10, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 10, 2023
@artem1205 artem1205 marked this pull request as ready for review November 10, 2023 15:52
@artem1205 artem1205 self-assigned this Nov 10, 2023
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 10, 2023 15:54
@artem1205 artem1205 enabled auto-merge (squash) November 13, 2023 23:01
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 14, 2023 14:43
@artem1205 artem1205 merged commit be6aebc into master Nov 14, 2023
24 of 25 checks passed
@artem1205 artem1205 deleted the artem1205/source-bing-ads-convert-float branch November 14, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants