Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Source Instagram: Include media_product_type in Media and Stories Schemas #32423

Merged

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Nov 10, 2023

What

This PR is a duplicate of the forked PR: #31947
Resolves: #28260

How

Added missing media_product_type property to the media.json and stories.json schema files.

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview Nov 13, 2023 7:11pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram labels Nov 10, 2023
Copy link
Contributor

github-actions bot commented Nov 10, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@tolik0 tolik0 marked this pull request as ready for review November 10, 2023 13:03
@tolik0 tolik0 requested a review from a team November 10, 2023 13:03
@tolik0 tolik0 force-pushed the pabloescoder/source-instagram/add-media-product-type-to-schema branch from 022d820 to 7c18312 Compare November 13, 2023 19:09
@tolik0 tolik0 merged commit bf41a37 into master Nov 14, 2023
25 checks passed
@tolik0 tolik0 deleted the pabloescoder/source-instagram/add-media-product-type-to-schema branch November 14, 2023 09:15
@tolik0 tolik0 self-assigned this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Instagram: It does not capture media_product_type column #28180
4 participants