New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Amazon Seller Partner: remove max_wait_seconds
from spec
#32462
Merged
artem1205
merged 12 commits into
master
from
artem1205/source-amazon-seller-partner-1658-max-time
Nov 17, 2023
Merged
🐛 Source Amazon Seller Partner: remove max_wait_seconds
from spec
#32462
artem1205
merged 12 commits into
master
from
artem1205/source-amazon-seller-partner-1658-max-time
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
connectors/source/amazon-seller-partner
labels
Nov 13, 2023
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
artem1205
changed the title
Source Amazon Seller Partner: remove max_wait_seconds from spec
🐛 Source Amazon Seller Partner: remove max_wait_seconds from spec
Nov 13, 2023
artem1205
changed the title
🐛 Source Amazon Seller Partner: remove max_wait_seconds from spec
🐛 Source Amazon Seller Partner: remove Nov 13, 2023
max_wait_seconds
from spec
…8-max-time # Conflicts: # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_rate_limits.py
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Nov 16, 2023
…azon-seller-partner-1658-max-time # Conflicts: # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json # docs/integrations/sources/amazon-seller-partner.md
askarpets
approved these changes
Nov 17, 2023
artem1205
deleted the
artem1205/source-amazon-seller-partner-1658-max-time
branch
November 17, 2023 21:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/amazon-seller-partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve
How
remove max_wait_seconds from spec
set default waiting interval for reporting service == 1hour
Recommended reading order
streams.py
spec.json
🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.