🐛 Source Mailchimp: Connection Check Error Handling

[ChristoGrab]

What

The Mailchimp API does not always raise HTTPErrors after failed requests. When accessing OAuth or Ping endpoints, inputting an incorrect credential will result in a 200 success response with a body consisting of a simple error object. Our current error handling during the connection_check method is not catching these errors, resulting in false positives and some misleading messages when checking the connection (ie KeyErrors on expected properties that are not being returned).

How

• Added error handling for invalid Oauth Access Tokens when fetching the token's data center.
• Added error handling during connection_check. If a specific error type and message is returned, the connector will include them in the response message. If not, a generic "Unknown Error" message will be returned.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Nov 14, 2023 7:11pm

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.