Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Instagram: Marked start_date as optional; set max retry time to 10 minutes #32494

Merged
merged 8 commits into from
Nov 15, 2023

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Nov 14, 2023

What

  • Updated the start_date configuration parameter to be optional.
  • Add missing field email_contacts to UserInsights.
  • Adjusted the backoff policy to have a maximum time limit of 10 minutes.
  • Add suggested streams.
  • Update docs with <HideInUI> and delete instagram.inapp.md.

How

Modified the configuration by making start_date optional with a default value set to two years ago.

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 11:44pm

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 14, 2023
@tolik0 tolik0 marked this pull request as ready for review November 14, 2023 10:55
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 14, 2023 10:56
@tolik0 tolik0 merged commit 3d48b92 into master Nov 15, 2023
28 checks passed
@tolik0 tolik0 deleted the tolik0/source-instagram/checklist-updates branch November 15, 2023 12:45
@tolik0 tolik0 self-assigned this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants