Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Amazon Seller Partner: added unexpected fields #32591

Conversation

darynaishchenko
Copy link
Collaborator

What

certification: add unexpected fields
from datadog dashboard:

stream:_get_fba_storage_fee_charges_data
average_quantity_customer_orders
average-quantity-on-hand
average-quantity-pending-removal,
base-rate,
breakdown-incentive-fee-amount
country-code,
dangerous-goods-storage-type
eligible-for-inventory-discount
estimated-monthly-storage-fee
estimated-total-item-volume
fulfillment-center
item_volume
longest-side
measurement-units
median-side
month-of-charge
product-name
product-size-tier
qualifies-for-inventory-discount
shortest-side
storage-utilization-ratio
storage-utilization-ratio-units
total-incentive-fee-amount
utilization-surcharge-rate
volume-units
weight-units

stream:_get_fba_inventory_planning_data
estimated-ais-181-210-days,
estimated-ais-211-240-days,
estimated-ais-241-270-days,
estimated-ais-271-300-days
estimated-ais-301-330-days,
estimated-ais-331-365-days,
estimated-ais-365-plus-days
quantity-to-be-charged-ais-181-210-days,
quantity-to-be-charged-ais-211-240-days,
quantity-to-be-charged-ais-241-270-days,
quantity-to-be-charged-ais-271-300-days,
quantity-to-be-charged-ais-301-330-days,
quantity-to-be-charged-ais-331-365-days
quantity-to-be-charged-ais-365-plus-days

stream:_get_ledger_detail_view_data
date_and_time

stream:_orders
shipping address

How

_get_fba_storage_fee_charges_data: revieved fields from dasboard and added missed fields - docs
_get_fba_inventory_planning_data: revieved fields from dasboard and added missed fields - docs
_get_ledger_detail_view_data: revieved fields from dasboard and added missed fields - docs
_orders: shipping address field already in orders.schema

@darynaishchenko darynaishchenko self-assigned this Nov 16, 2023
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 9:04am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-seller-partner labels Nov 16, 2023
Copy link
Contributor

github-actions bot commented Nov 16, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@askarpets askarpets changed the base branch from master to source-amazon-seller-partner November 21, 2023 08:46
…-seller-partner/unexpected-fields

# Conflicts:
#	airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml
#	docs/integrations/sources/amazon-seller-partner.md
@askarpets askarpets merged commit 20f312c into source-amazon-seller-partner Nov 21, 2023
26 checks passed
@askarpets askarpets deleted the daryna/source-amazon-seller-partner/unexpected-fields branch November 21, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants