Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3, Azure Blob Storage, GCS, Weviate, Milvus, Chroma, Qdrant: Bump cdk version #32608

Merged
merged 10 commits into from
Nov 30, 2023
Merged

S3, Azure Blob Storage, GCS, Weviate, Milvus, Chroma, Qdrant: Bump cdk version #32608

merged 10 commits into from
Nov 30, 2023

Conversation

flash1293
Copy link
Contributor

Bump CDK version for a bunch of connectors to pull in most recent changes:

@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 3:00pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited by flash1293
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 16, 2023
girarda
girarda approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but you have a merge conflict on airbyte-integrations/connectors/source-bing-ads/metadata.yaml :shipit:

@flash1293 flash1293 marked this pull request as ready for review November 27, 2023 14:13
@flash1293 flash1293 requested a review from a team as a code owner November 27, 2023 14:13
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 27, 2023 14:14
lazebnyi
lazebnyi approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flash1293 flash1293 mentioned this pull request Nov 29, 2023
Closed
@flash1293 flash1293 merged commit 8f7abc2 into master Nov 30, 2023
30 checks passed
@flash1293 flash1293 deleted the flash1293/bump-cdk branch November 30, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/chroma connectors/destination/milvus connectors/destination/qdrant connectors/destination/weaviate connectors/source/azure-blob-storage connectors/source/bing-ads connectors/source/gcs connectors/source/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flash1293 @girarda @lazebnyi @octavia-squidington-iii