🐛 Source Github: return AirbyteMessage if max retry exeeded for 202 status code

[darynaishchenko]

What

resolved: https://github.com/airbytehq/oncall/issues/3294
They are receiving the Unexpected type for data_or_message: <class 'NoneType'>: None error.

How

NoneType error occurs because we have incorrect handling of 202 status code response if max retry reached. Added yield AirbyteMessage instead of yield to fix NoneType error. So now we can skip this stream if data is still computing on github side after 6 retries.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 10:57am

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[maxi297]

🚢

[davydov-d]

let's reproduce this bug in a test so we would not miss it again

[darynaishchenko]

this test reproduces this "bug", None is not returning now from read records so read results now can be correctly parsed in https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/python/airbyte_cdk/sources/utils/record_helper.py#L14.

[darynaishchenko]

/approve-and-merge reason="Fixing on-call issue with github source connector to handle 202 status code error correctly."

[octavia-approvington]

Lets merge it