Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector DB destinations: Add omit_raw_text flag and increase code reuse #32697

Merged
merged 14 commits into from Dec 4, 2023

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Nov 21, 2023

This PR makes the changes from #32698 available in all vector db destinations.

@flash1293 flash1293 requested a review from a team as a code owner November 21, 2023 13:55
@flash1293 flash1293 marked this pull request as draft November 21, 2023 13:55
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 9:30am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Nov 21, 2023
Base automatically changed from flash1293/do-not-store-text-flag to master November 30, 2023 08:49
Joe Reuter and others added 5 commits November 30, 2023 11:46
Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@flash1293 flash1293 merged commit e7f8165 into master Dec 4, 2023
26 checks passed
@flash1293 flash1293 deleted the flash1293/roll-out-raw-text-store-flag branch December 4, 2023 16:45
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
airbytehq#32697)

Co-authored-by: flash1293 <flash1293@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants