New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Twilio: Increase test coverage, fix parse_response bug, update expected records, migrate base image #32718
Conversation
…updated expected records
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
… expected records, migrate base image (#32718) Co-authored-by: pnilan <pnilan@users.noreply.github.com>
… expected records, migrate base image (#32718) Co-authored-by: pnilan <pnilan@users.noreply.github.com>
What
How
parse_response
updated and returned records. Records wouldyield
prior to all fields included inchangeable_fields
being removed. Additionally, all records wouldyield
again at the end of the method, resulting in duplicated records.