airbyte-ci: bump tag, update readme, remove 'nightly_builds' #32806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Nov 24, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
postamar
force-pushed
the
postamar_gt_11-24-airbyte-ci_correct_time-travelling_behaviour_for_cron_jobs
branch
from
20b2931
to
f348a0f
Compare
postamar
changed the title
postamar
force-pushed
the
postamar_gt_11-24-airbyte-ci_correct_time-travelling_behaviour_for_cron_jobs
branch
from
f348a0f
to
ba268a8
Compare
bnchrch
approved these changes
Nov 24, 2023
| async def get_modified_files_since(current_git_branch: str, current_git_revision: str, since: str, is_local: bool = True) -> Set[str]: | ||
| # TODO: implement | ||
| return await get_modified_files_in_commit(current_git_branch, current_git_revision, is_local) | ||
| if is_local: |
There was a problem hiding this comment.
Thanks for filling out the helper!
| @@ -74,9 +72,30 @@ async def get_modified_files_in_commit(current_git_branch: str, current_git_revi | |||
| return await get_modified_files_in_commit_remote(current_git_branch, current_git_revision) | |||
|
|
|||
|
|
|||
| def get_modified_files_since_local(current_git_revision: str, since: str) -> Set[str]: | |||
There was a problem hiding this comment.
I'd appreciate since to be a datetime / date object and make the function perform a strftime to cast it to string.
Comment on lines
75
to
83
| def get_modified_files_since_local(current_git_revision: str, since: str) -> Set[str]: | ||
| airbyte_repo = git.Repo() | ||
| diffed_git_revision = airbyte_repo.git.log(current_git_revision, f"--before='{since}'", "--max-count=1", "--pretty=%H").strip() | ||
| return get_modified_files_local(current_git_revision, diffed_git_revision) | ||
|
|
||
|
|
||
| async def get_modified_files_since_remote(current_git_branch: str, current_git_revision: str, since: str) -> Set[str]: |
There was a problem hiding this comment.
I don't find these two helpers being used? Or am I missing coffee? If they're not used yet I'm not sure the version bump should happen in this branch.
There was a problem hiding this comment.
You're missing coffee. In any case I just got rid of them. I'm going to merge this stack just to fix the stacked pull request behaviour.
postamar
force-pushed
the
postamar_gt_11-24-airbyte-ci_correct_type_annotation_deterministic_transform_strs_to_paths_behaviour
branch
from
e9c2a7d
to
850daee
Compare
postamar
force-pushed
the
postamar_gt_11-24-airbyte-ci_correct_time-travelling_behaviour_for_cron_jobs
branch
from
ba268a8
to
7b5e8e3
Compare
postamar
force-pushed
the
postamar_gt_11-24-airbyte-ci_correct_type_annotation_deterministic_transform_strs_to_paths_behaviour
branch
from
e97b5fd
to
54307a1
Compare
postamar
force-pushed
the
postamar_gt_11-24-airbyte-ci_correct_time-travelling_behaviour_for_cron_jobs
branch
from
541c18d
to
210b58e
Compare
postamar
changed the title
postamar
force-pushed
the
postamar_gt_11-24-airbyte-ci_correct_type_annotation_deterministic_transform_strs_to_paths_behaviour
branch
from
138055e
to
71c4cb7
Compare
postamar
force-pushed
the
postamar_gt_11-24-airbyte-ci_correct_time-travelling_behaviour_for_cron_jobs
branch
from
11d0983
to
d64321e
Compare
postamar
changed the base branch from
postamar_gt_11-24-airbyte-ci_correct_type_annotation_deterministic_transform_strs_to_paths_behaviour
to
master
|
/approve-and-merge reason="blocked by docker pull rate limit" |
|
Myomoto says it looks good |
octavia-approvington
approved these changes
Nov 27, 2023
octavia-approvington
deleted the
postamar_gt_11-24-airbyte-ci_correct_time-travelling_behaviour_for_cron_jobs
branch
octavia-approvington
pushed a commit
that referenced
this pull request
Nov 27, 2023
postamar
added a commit
that referenced
this pull request
Nov 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the "nightly_builds" CI_CONTEXT value.
This PR changes the behaviour of --modified when CI_CONTEXT is "nightly_builds" or "weekly_builds".Presently, when--modifiedand either of those CI_CONTEXT values are set, airbyte-ci determines which connectors have been modified by looking only at which connectors were changed in whatever happens to be the HEAD commit on the master branch at that time.This is certainly not what anyone wants.
This PR changes this to look at the connectors changed in HEAD and all of its ancestors up until a certain date.This cutoff date is '1 day ago' for nightlies and '1 week ago' for weeklies.