-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨🚨🐛 Source Mailchimp: Multiple schema updates and fixes #32836
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@ChristoGrab Can you please add type for the |
…risto/mailchimp-fixes
…q/airbyte into christo/mailchimp-fixes
Version 1.0.0 introduces schema changes to all incremental streams. | ||
A full schema refresh and data reset are required to upgrade to this version. | ||
For more details, see our <a href='https://docs.airbyte.io/integrations/sources/mailchimp-migrations'>migration guide</a>. | ||
upgradeDeadline: "2023-12-21" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"2024-01-10"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍
What
This PR introduces multiple breaking changes to Source Mailchimp's schema:
Timestamp fields have been updated from
string
to airbyte-typetimestamp_with_timezone
. In order to accommodate this change, emptystring
values are now converted tonull
for incremental streams. This is necessary as there are multiple timestamp fields which, when they do not contain a value, will be returned as empty strings by the API, causing validation errors on the declared date-time format.The
._links
field, which contains non-user relevant Mailchimp metadata, has been excluded from all requests, and removed from our schema (it was only declared in the Automations schema). This field was already being excluded from recently added streams, and since this update already constitutes a breaking change, now is a good time to filter it out entirely.Docs updates
HideInUI
tags to non-setup sections, and collapsible Troubleshooting sectionMisc
._links
field from individual stream implementation to base MailchimpStream classrequest_params
.integration_tests/state.json
🚨🚨 User Impact
Due to the changes in type to all timestamp fields, and the removal of the
._links
fields from the schema, this is a breaking change affecting all Incremental streams. Customers will have to refresh their schemas and reset data in order to upgrade.