Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Sentry: Increases Test Coverage, Migrates Base Image, adds missing field to schema, updates QL #32957

Merged
merged 29 commits into from Jan 5, 2024
Merged

Source Sentry: Increases Test Coverage, Migrates Base Image, adds missing field to schema, updates QL #32957

merged 29 commits into from Jan 5, 2024

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Nov 29, 2023 •
edited

What

  • Updates QL to 200 per request
  • Increases test coverage to exceed 90% minimum requirement
  • Migrates to new base image
  • Adds hasFeedbacks to projects and project_detail schemas
  • Temporarily enables empty_records for Issues and Events streams to pass CAT.
  • Updates changelog and version numbers accordingly
  • Resolves Source Sentry - Increase Test Coverage #32649

roman-yermilov-gl and others added 11 commits November 20, 2023 14:52
@roman-yermilov-gl
Source Hubspot: fix expected records (#32645)
b611729
@roman-yermilov-gl
Source Github: fix expected records (#32644)
a9cc2b9
@ChristoGrab
✨ Source Mailchimp: Add Interests, InterestCategories, Tags streams (#…
e74bbde 
…32218)
@tolik0
🐛 Source Pinterest: Fix backoff waiting time (#32672)
918e64c
@tolik0
🚨🚨🐛 Source Pinterest: Update date-time fields with airbyte_type: time…
0f28144 
…stamp_without_timezone (#32595)
@edgao
remove bq+snowflake from legacy normalization docs (#32708)
39ac79c
@pnilan
Added additional testing -- 89% coverage
cd4682e
@pnilan
Added unit test to test parse response for incremental stream. Test c…
ebdbd09 
…overage now exceeds 90%.
@pnilan
Added 'hasFeedbacks' field to projects.json and project_detail.json s…
6a9d1e7 
…chemas
@pnilan
Update connector version to reflect minor change
0f325c5
@pnilan
Merge branch 'master' into pnilan/source-sentry-test-coverage
17df42d
@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 8:32pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry labels Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 29, 2023 20:49
@pnilan pnilan closed this Nov 29, 2023
@pnilan pnilan reopened this Nov 30, 2023
@pnilan pnilan force-pushed the pnilan/source-sentry-test-coverage branch from f3e92ea to 4fb38f7 Compare December 6, 2023 00:39
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 6, 2023 00:40
@pnilan pnilan force-pushed the pnilan/source-sentry-test-coverage branch from ce2ccf7 to c0b58d1 Compare December 6, 2023 17:38
@pnilan pnilan force-pushed the pnilan/source-sentry-test-coverage branch from 6452fe7 to 64bc7df Compare December 7, 2023 20:52
@pnilan pnilan requested a review from lazebnyi January 5, 2024 20:35
@pnilan pnilan merged commit 5c6f4f2 into master Jan 5, 2024
23 of 24 checks passed
@pnilan pnilan deleted the pnilan/source-sentry-test-coverage branch January 5, 2024 20:38
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@pnilan @roman-yermilov-gl
@ChristoGrab @tolik0 @edgao @jatinyadav-cc
Source Sentry: Increases Test Coverage, Migrates Base Image, adds mis…
67cb7f9 
…sing field to schema, updates QL (airbytehq#32957)

Co-authored-by: Roman Yermilov [GL] <86300758+roman-yermilov-gl@users.noreply.github.com>
Co-authored-by: Christo Grabowski <108154848+ChristoGrab@users.noreply.github.com>
Co-authored-by: Anatolii Yatsuk <35109939+tolik0@users.noreply.github.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@pnilan @roman-yermilov-gl
@ChristoGrab @tolik0 @edgao @jatinyadav-cc
Source Sentry: Increases Test Coverage, Migrates Base Image, adds mis…
58dc801 
…sing field to schema, updates QL (airbytehq#32957)

Co-authored-by: Roman Yermilov [GL] <86300758+roman-yermilov-gl@users.noreply.github.com>
Co-authored-by: Christo Grabowski <108154848+ChristoGrab@users.noreply.github.com>
Co-authored-by: Anatolii Yatsuk <35109939+tolik0@users.noreply.github.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@pnilan @roman-yermilov-gl
@ChristoGrab @tolik0 @edgao @jatinyadav-cc
Source Sentry: Increases Test Coverage, Migrates Base Image, adds mis…
deecee4 
…sing field to schema, updates QL (airbytehq#32957)

Co-authored-by: Roman Yermilov [GL] <86300758+roman-yermilov-gl@users.noreply.github.com>
Co-authored-by: Christo Grabowski <108154848+ChristoGrab@users.noreply.github.com>
Co-authored-by: Anatolii Yatsuk <35109939+tolik0@users.noreply.github.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnchrch bnchrch bnchrch approved these changes

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Sentry - Increase Test Coverage
7 participants
@pnilan @bnchrch @octavia-squidington-iii @roman-yermilov-gl @ChristoGrab @tolik0 @edgao