Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-postgres : Bump DBZ default time to 1200 sec #32961

Merged
merged 8 commits into from Nov 30, 2023
Merged

source-postgres : Bump DBZ default time to 1200 sec #32961

merged 8 commits into from Nov 30, 2023

Conversation

akashkulk
Copy link
Contributor

@akashkulk akashkulk commented Nov 29, 2023 •
edited

We've seen that DBZ times out fairly frequently, since it takes some time for heartbeat events to be emitted.

For many OC issues, bumping up the timeout from 5 min -> 20 min has helped. In this PR, we do it by default. For the happy case, this will NOT affect speed of sync, since this time is reset when we receive the first record.

Part of effort detailed in #32946

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ❌ Failed (Inspect) Nov 30, 2023 5:19pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 29, 2023
@akashkulk akashkulk marked this pull request as ready for review November 29, 2023 21:43
@akashkulk akashkulk requested a review from a team as a code owner November 29, 2023 21:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited

Coverage report for source-postgres

File Coverage [85.15%] 🍏
PostgresUtils.java 85.15% 🍏
Total Project Coverage 71.66% 🍏

postamar
postamar reviewed Nov 29, 2023
View reviewed changes
airbyte-integrations/connectors/source-postgres/src/main/resources/spec.json Outdated
@@ -265,7 +265,7 @@
"type": "integer",
"title": "Initial Waiting Time in Seconds (Advanced)",
"description": "The amount of time the connector will wait when it launches to determine if there is new data to sync or not. Defaults to 300 seconds. Valid range: 120 seconds to 1200 seconds. Read about <a href=\"https://docs.airbyte.com/integrations/sources/postgres#step-5-optional-set-up-initial-waiting-time\">initial waiting time</a>.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the description, it says it defaults to 300 seconds. Also, consider raising the upper bound of the valid range, perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - done!

@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 29, 2023 21:51
@akashkulk akashkulk merged commit c73e751 into master Nov 30, 2023
23 of 25 checks passed
@akashkulk akashkulk deleted the akash/bump-pg-dbz-default branch November 30, 2023 17:40
@cynthiaxyin cynthiaxyin mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postamar postamar postamar approved these changes

@prateekmukhedkar prateekmukhedkar prateekmukhedkar approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-search-console connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akashkulk @postamar @prateekmukhedkar @octavia-squidington-iii