-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Close.com: add support for custom fields #32984
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
9182242
to
b505d92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment.
airbyte-integrations/connectors/source-close-com/source_close_com/source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtruty I'll merge the contribution tmw
Merged at #34286 |
What
This is adding custom fields to the close source connector for streams that contain custom fields. Without this change, custom fields cannot be imported, as the entire schema is static.
How
Describe the solution
We add to the yaml schema dynamically by loading custom fields from an api endpoint. The static schema fields are not changed (and there is no api endpoint to get these).
Custom field docs: https://developer.close.com/resources/custom-fields/
Recommended reading order
airbyte-integrations/connectors/source-close-com/source_close_com/source.py
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
No breaking changes, just more fields available in the schema if the user has custom fields attached to an object.
Minor version bump
Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.