fix multi arch build

[alafanechere]

What

#32816 changed the way we load dagger-built container to local docker images.
We used docker import instead of docker load.
When using docker import we import a container filesystem as an image. Container filesystem can't be run as connector: they don't have entry points, env var, etc. set.
This is why we faced errors like:

$ docker run airbyte/destination-redshift:dev spec
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "spec": executable file not found in $PATH: unknown.

Using docker load works better, but did not work for "multi arch" containers.

After deeply investigating I realize there's no such thing as a local multi arch docker image. Multi-arch images are only a docker registry thing: a docker manifest points to arch-specific images/layers and on pull the docker client pulls the correct image for the current architecture after reading the manifest.
In other words: there's no way to locally build a multi-arch image, either with docker or dagger.
But it's possible to have a local image built for a different architecture.

Now that I better understand the multi arch concept I change the --architecture option on build.
If you pass multiple --architecture you'll get multiple local images with architecture tag suffix:

• airbyte/source-faker:dev-linux-arm64
• airbyte/source-faker:dev-linux-amd64

If you pass a single --architecture you'll get:

• airbyte/source-faker:dev built for the architecture option value

If you pass no --architecture option you'll get:

• airbyte-/source-faker:dev built for your current architecture.

How

• Use docker load instead o docker import
• Implement the logic described above
• Add a test to spot the kind of regression that originally happen: run spec on the loaded docker image.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Dec 4, 2023 1:49pm

[alafanechere]

Current dependencies on/for this PR:

• master
  • PR Revert "Fix: Revert airbyte-ci to 2.8.0 from 2.10.0 (#32954)" #32955
    • PR fix multi arch build #33008 👈

This stack of pull requests is managed by Graphite.

[bnchrch]

Good deep diving! Interesting findings! Great Code!

Nothing blocking

[bnchrch]

💅 Can be useful to have title transforms named

Suggested change

	image_tag = f"{self.image_tag}-{platform.replace('/', '-')}" if multi_platforms else self.image_tag
	image_tag = _generate_dev_tag(self.image_tag, platform, multi_platforms=multi_platforms)

That way you can contain the why

def _generate_dev_tag(image_tag, platform, multi_platforms):
    """
    Explain that multi archecture dev builds are not possible
    """
    return f"{self.image_tag}-{platform.replace('/', '-')}" if multi_platforms else self.image_tag