New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Hubspot: Web Analytics API #33042
Source Hubspot: Web Analytics API #33042
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
969eda3
to
cd8e794
Compare
68bf482
to
11ac4d3
Compare
11ac4d3
to
cf582e7
Compare
6bc220d
to
94d3da9
Compare
64c0886
to
1589260
Compare
5891e59
to
a8240d9
Compare
f1236ab
to
c232485
Compare
9d853db
to
0562a0a
Compare
airbyte-integrations/connectors/source-hubspot/source_hubspot/source.py
Outdated
Show resolved
Hide resolved
98a850d
to
f7f6d7e
Compare
Hi, why was this merged, despite CI being red on it? The doc changes broke master. @roman-yermilov-gl could you please open another PR to fix the issues with the docs.
|
^ Specifically I think the issue is that you can't use a |
I think it might be related to this (https://github.com/airbytehq/airbyte/blob/master/docs/integrations/sources/hubspot.md?plain=1#L194) being a self-closing tag, but then closed in line 200 again. |
@timroes CI was green, all tests were passed and I had one approve |
@timroes Let me fix this self-closing tag in additional PR |
@timroes @erohmensing |
Co-authored-by: roman-yermilov-gl <roman-yermilov-gl@users.noreply.github.com>
What
Implement Web Analytics streams: #32702
How
Implemented new Web Analytics streams:
Implement client side incremental sync
Make streams to share same schema for default properties
Make a toggle to turn on/off web analytics streams