Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination bigquery: further increase gcs COPY timeout #33078

Merged
merged 2 commits into from Dec 5, 2023
Merged

Destination bigquery: further increase gcs COPY timeout #33078

merged 2 commits into from Dec 5, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Dec 4, 2023

@edgao edgao requested a review from a team as a code owner December 4, 2023 22:38
@vercel Vercel
Copy link

vercel bot commented Dec 4, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 11:22pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023 •
edited by edgao

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

evantahler
evantahler reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to need all the version and docs shenanigans - airbyte-ci has got you:

airbyte-ci connectors --name destination-bigquery bump_version patch 33078 "Further increase gcs COPY timeout"

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 4, 2023
@edgao edgao merged commit 7863298 into master Dec 5, 2023
26 of 28 checks passed
@edgao edgao deleted the edgao/bigquery/gcs_timeout branch December 5, 2023 00:34
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
@edgao @rishabh-cldcvr
Destination bigquery: further increase gcs COPY timeout (airbytehq#33078
b90d18b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edgao @evantahler @octavia-squidington-iii