airbyte-ci: Clean all pyenv shims #33080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
erohmensing
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
since we're using it for url lib, maybe hook-urllib.py?
|
|
||
| def get_ssl_context(): | ||
| """ | ||
| Returns an ssl.SSLContext object with the custom certificate file if certifi is installed, otherwise |
| Returns the path to the custom certificate file if certifi is installed, otherwise None. | ||
|
|
||
| HACK: This is a workaround for the fact that the pyinstaller binary does not know how or where to | ||
| find the ssl certificates file. This is a problem because the binary is built on a different system |
There was a problem hiding this comment.
Suggested change
| find the ssl certificates file. This is a problem because the binary is built on a different system | |
| find the ssl certificates file. This happens because the binary is built on a different system |
Comment on lines
28
to
35
| WHY: this works when certifi is not found: | ||
| If you run this file directly, it will use the system python interpreter and will be able to find | ||
| the ssl certificates file. | ||
|
|
||
| WHY: this works when certifi is found: | ||
| When this file is run by the pyinstaller binary, it is through the pipelines project, which has | ||
| certifi installed. This means that when this file is run by the pyinstaller binary, it will be able | ||
| to find the ssl certificates file in the certifi package. |
There was a problem hiding this comment.
This is great. I'd add "e.g. when running in dev mode" to the top.
rishabh-cldcvr
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Dec 14, 2023
Co-authored-by: erohmensing <erohmensing@gmail.com> Co-authored-by: bnchrch <bnchrch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you uninstall
pipelines(e.g.airbyte-ci) from pyenv, it can be readded if it exists in anyother pyenv paths viapyenv init -. A common line in users.zshrcfileSolution
Clean out any path located at
pyenv whence --path airbyte-cicloses #33086