New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Bing Ads: added account filtering #33095
✨ Source Bing Ads: added account filtering #33095
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@artem1205 , added check for unique accounts |
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
FOR REVIEWERS: CAT test are failing now. I'm working on it in this pr #32704
What
Based on user experience: all accounts are synced, but for users with a lot of accounts have received all of them which is not easy to filter on destination for some cases.
How
To skip data that is not relevant for users was added filtering by setting up a list predicates in config. Predicate is a object of operator(Contains or Equals) and value to compare. User can define multiple predicates pairs that will be used in slicing for making a request params and to fetch only account that fits predicates.