Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Bing Ads: added account filtering #33095

Merged

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Dec 5, 2023

FOR REVIEWERS: CAT test are failing now. I'm working on it in this pr #32704

What

Based on user experience: all accounts are synced, but for users with a lot of accounts have received all of them which is not easy to filter on destination for some cases.

How

To skip data that is not relevant for users was added filtering by setting up a list predicates in config. Predicate is a object of operator(Contains or Equals) and value to compare. User can define multiple predicates pairs that will be used in slicing for making a request params and to fetch only account that fits predicates.

image

@darynaishchenko darynaishchenko self-assigned this Dec 5, 2023
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 4:48pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads labels Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@darynaishchenko
Copy link
Collaborator Author

@artem1205 , added check for unique accounts

@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 13, 2023 11:54
@darynaishchenko darynaishchenko merged commit f8da0be into master Dec 13, 2023
25 of 26 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-bing-ads/set-up-account-in-config branch December 13, 2023 17:14
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants