Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [source-klaviyo] Use latest CDK and continue syncing even if a stream fails #33237

Merged
merged 2 commits into from Dec 11, 2023

Conversation

brianjlai
Copy link
Contributor

Temporarily includes the test code to validate the fix works with the latest CDK. The bad code will be removed before merging

Closes #29882

What

Modifies the klaviyo source to uptake the latest CDK changes which allows the source to continue a sync even when one of the streams exits due to a failure during the sync

How

Overrides the new continue_sync_on_stream_failure() method which will cause it to keep syncing which was introduced in 0.56.0 #33136

Again I will highlight that this will impact our ability to group Sentry errors together so we should be conservative where we apply this fix while we work on the proper interface.

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 0:04am

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@brianjlai brianjlai changed the title update klaviyo to use latest CDK and continue syncing even with strea… ✨ [source-klaviyo] Use latest CDK and continue syncing even if a stream fails Dec 7, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 8, 2023
@brianjlai brianjlai marked this pull request as ready for review December 8, 2023 00:11
@brianjlai brianjlai requested a review from a team December 8, 2023 00:11
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 8, 2023 00:12
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@brianjlai brianjlai merged commit 5a4d64a into master Dec 11, 2023
29 of 31 checks passed
@brianjlai brianjlai deleted the brian/klaviyo_continue_syncing_if_stream_fails branch December 11, 2023 17:45
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/klaviyo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK: Let other streams run even if a stream fails
3 participants