New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [source-klaviyo] Use latest CDK and continue syncing even if a stream fails #33237
✨ [source-klaviyo] Use latest CDK and continue syncing even if a stream fails #33237
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Temporarily includes the test code to validate the fix works with the latest CDK. The bad code will be removed before merging
Closes #29882
What
Modifies the klaviyo source to uptake the latest CDK changes which allows the source to continue a sync even when one of the streams exits due to a failure during the sync
How
Overrides the new
continue_sync_on_stream_failure()
method which will cause it to keep syncing which was introduced in0.56.0
#33136Again I will highlight that this will impact our ability to group Sentry errors together so we should be conservative where we apply this fix while we work on the proper interface.