Airbyte-ci: Add path warning to check

[bnchrch]

Problem

$HOME/.local/bin/airbyte-ci is not on the path by default

Solution

1. During check ensure that it is
2. If not output an error with instructions of how to resolve

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 12, 2023 7:41pm

[alafanechere]

I'm not sure I get what's exactly checking that \$HOME/.local/bin is part of the PATH
Could we have a prior step that just checks:

• ~/.local/bin directory exists
• That this path is part of the $PATH variable?

[bnchrch]

Good catch. I had the absense of airbyte-ci as an indication of a improper path.

Update these to be separate checks

[erohmensing]

LGTM!

[erohmensing]

Super nit: we could set this AIRBYTE_CI_PATH variable earlier, and check whether it is empty on L21 instead of running the command twice. E.g.

Suggested change

	# Check that airbyte-ci is on the PATH
	# If not print an error message and exit
	if ! which airbyte-ci >/dev/null 2>&1; then
	echo "airbyte-ci is not installed"
	echo ""
	echo "Please run 'make tools.airbyte-ci.install' to install airbyte-ci"
	exit 1
	fi
	EXPECTED_PATH="$INSTALL_DIR/airbyte-ci"
	AIRBYTE_CI_PATH=$(which airbyte-ci 2>/dev/null)
	# Check that airbyte-ci is on the PATH
	AIRBYTE_CI_PATH=$(which airbyte-ci 2>/dev/null)
	# If not print an error message and exit
	if [ -z "$AIRBYTE_CI_PATH" ]; then
	echo "airbyte-ci is not installed"
	echo ""
	echo "Please run 'make tools.airbyte-ci.install' to install airbyte-ci"
	exit 1
	fi
	EXPECTED_PATH="$INSTALL_DIR/airbyte-ci"

[erohmensing]

I guess my only question is "if I hit this right after (trying to) installing airbyte ci, then what?"

But i guess the answer is come talk to connector ops :D