Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airbyte-ci: fix credentials bug #33248

Merged
merged 3 commits into from
Dec 8, 2023
Merged

airbyte-ci: fix credentials bug #33248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ce8a62
airbyte-ci: fix credentials bug
postamar Dec 8, 2023
b89042b
Automated Commit - Formatting Changes
postamar Dec 8, 2023
33314b2
bump version and update changelog
postamar Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ This command runs the Python tests for a airbyte-ci poetry package.
## Changelog
| Version | PR | Description |
| ------- | ---------------------------------------------------------- | --------------------------------------------------------------------------------------------------------- |
| 2.10.7 | [#33248](https://github.com/airbytehq/airbyte/pull/33248) | Fix bug which broke airbyte-ci connectors tests when optional DockerHub credentials env vars are not set. |
| 2.10.6 | [#33170](https://github.com/airbytehq/airbyte/pull/33170) | Remove Dagger logs from console output of `format`. |
| 2.10.5 | [#33097](https://github.com/airbytehq/airbyte/pull/33097) | Improve `format` performances, exit with 1 status code when `fix` changes files. |
| 2.10.4 | [#33206](https://github.com/airbytehq/airbyte/pull/33206) | Add "-y/--yes" Flag to allow preconfirmation of prompts |
Expand Down
8 changes: 6 additions & 2 deletions airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/metadata/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,12 @@ def __init__(self, context: ConnectorContext):
MountPath(INTERNAL_TOOL_PATHS.METADATA_SERVICE.value),
],
secrets={
"DOCKER_HUB_USERNAME": context.docker_hub_username_secret,
"DOCKER_HUB_PASSWORD": context.docker_hub_password_secret,
k: v
for k, v in {
"DOCKER_HUB_USERNAME": context.docker_hub_username_secret,
"DOCKER_HUB_PASSWORD": context.docker_hub_password_secret,
}.items()
if v
},
command=[
"metadata_service",
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/pipelines/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "pipelines"
version = "2.10.6"
version = "2.10.7"
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
authors = ["Airbyte <contact@airbyte.io>"]

Expand Down
Loading